michaelbromley / michaelbromley/angularUtils

Breadcrumbs does not support variables with ui-router v1.0.0-rc.1

Open
#435 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2k
Forks
842
PR merge metrics
No merged PRs in 30d

Description

Hello

Assuming I have this,

data : { breadcrumbsLabel : ' User {{ user.name }} name' }

Breadcrumbs will render "User name", missing actual user.name variable value.
Something is changed in ui-router and soon this directive will stop work when they release.
I tracked down that is currentState.locals is undefined.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the breadcrumbs directive and tracing how it reads currentState.locals when using ui-router v1.0.0-rc.1. Reproduce the example with the user.name variable, then verify that the rendered breadcrumb includes its value rather than only the surrounding label text.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.