michaelbromley / michaelbromley/angularUtils

dirDisqus: TypeError: Cannot read property 'disqus_shortname' of undefined

Open
#368 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2k
Forks
842
PR merge metrics
No merged PRs in 30d

Description

Hi Michael,

Your dirDisqus directive is really helpful. Thanks for making it available on github.

I have used it on my site but seeing a js error in console. You can check the same here: https://prasadnevase.com/hello-world

While the error is not affecting comments functionality at the moment, I would like to fix that and not sure how it can be fixed. Could you please advise?

Thanks in advance.

Below is the code in my app.js single article controller:

        $scope.disqusConfig = {
            disqus_shortname: 'myshortname',
            disqus_identifier: $scope.post.id,
            disqus_url: $scope.post.link
        };

Below is the directive tag I have added in my single article view/template:

<dir-disqus config="disqusConfig"></dir-disqus>

Below is the error screenshot just for your info:

dirdisqus-console-error

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the dirDisqus directive entry point and reproduce the console error using the supplied disqusConfig and template. Compare the directive's expected configuration timing or shape with the controller example; done means the TypeError is gone while comments continue to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.