michaelbromley / michaelbromley/angularUtils

href route template attribute

Open
#234 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2k
Forks
842
PR merge metrics
No merged PRs in 30d

Description

Currently the pagination controls have anchors with an empty href in them.
You can change this by overriding the template, but it would be nice to have an attribute where you can pass in a route.
Example:

``` html

```

In this case people could just use this attribute instead of the callback if they only change the location in the callback.
But for me the main benefit is from a SEO standpoint, so browsers can follow the links.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the dir-pagination-controls directive and its anchor template, then inspect how the callback and href are currently handled. Done means an href-template such as /blog/page/:pageNumber can generate browser-followable pagination links without requiring the callback.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, javascript
Domain
frontend, web-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.