michaelbromley / michaelbromley/angularUtils
uiBreadcrumbs: Interpolation Context problem
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2k
- Forks
- 842
- PR merge metrics
- No merged PRs in 30d
Description
I found that using {{ }} in the state.display attribute ( to reference "resolved" data ) only worked when on that state, and did not work when on a child of that state.
I fixed it by changing the code in "getDisplayName()":
When there is no "state.locals", I changed it to instead use "$state.$current.locals.globals"
This made my {{ interpolation }} work at all levels.
It works because the "resolved" data from the parent state is also visible from child state.
(sorry, no PR)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate getDisplayName() in the AngularJS components and trace how it selects locals for state.display interpolation. Reproduce the parent-state and child-state cases described in the issue, then verify that resolved data interpolates correctly at both levels.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angularjs, javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100