michaelbromley / michaelbromley/angularUtils

Pagination: pageChanged handler should accept `newPageSize` when working with Asynchronous Data

Open
#212 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
2k
Forks
842
PR merge metrics
No merged PRs in 30d

Description

When working with Asynchronous Data, a change in `pageSize` should re-trigger an async call as well (and possibly do some recalculation):

```
$scope.pageChanged = function(newPage, newPageSize) {
getResultsPage(newPage, newPageSize);
};
```

```

```
- Implementation example: How **UI Grid** handles pagination: http://ui-grid.info/docs/#/api/ui.grid.pagination.api:PublicAPI#events_paginationchanged
- Dependant on: https://github.com/michaelbromley/angularUtils/issues/211

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the dir-pagination-controls on-page-change implementation and how it handles asynchronous data. Compare the event behavior with the linked UI Grid paginationchanged example and review dependent issue #211. Done means pageChanged can receive newPageSize so asynchronous calls can react to page-size changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.