michaelbromley / michaelbromley/angularUtils
Vendor folder is missing angular-mocks and angular-ui-router to run unit tests
- Dominant language
- JavaScript
- Stars
- 2k
- Forks
- 842
- PR merge metrics
- No merged PRs in 30d
Description
I was looking at add a feature to your awesome pagination directive. My first step for this was to get the existing unit tests up and running on grunt. When I ran the tests they failed with two warnings saying:
```
Running "karma:unit" (karma) task
WARN [watcher]: Pattern "C:/Work/angularUtils/vendor/angular-mock/angular-mock.js" does not match any file.
WARN [watcher]: Pattern "C:/Work/angularUtils/vendor/angular-ui-router/release/angular-ui-router.js" does not match any file.
```
I managed to dig up these files and get the unit tests passing but it might be handy if these were included in your vendor folder on GitHub.
Keep up the awesome work!
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the Grunt/Karma unit-test configuration and the two missing paths: vendor/angular-mock/angular-mock.js and vendor/angular-ui-router/release/angular-ui-router.js. Restore the required files in the vendor folder, then run the grunt karma:unit task and confirm the missing-file warnings are gone and the unit tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angularjs
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100