mia-platform / mia-platform/custom-plugin-lib
Remove required env variables
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 25
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
## The feauture or bug you are proposing
Here are set the default variables required by the cpl https://github.com/mia-platform/custom-plugin-lib/blob/b7dd0ea65303b51d909f706991a9efb3b5899e51/index.js#L43-L95
For example, there is also the `MICROSERVICE_GATEWAY_SERVICE_NAME` env var, also if microservice-gateway does not exists in project.
For my point of view, it's ok which are configurable but this env should not be required. Also, the `MICROSERVICE_GATEWAY_SERVICE_NAME` should be optional and enable/disable the pre/post decorator function (raising an error).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with index.js lines 43-95, which define the default environment variables required by the custom-plugin-lib. Check how MICROSERVICE_GATEWAY_SERVICE_NAME is used by the pre/post decorator functions. Done means configurable variables are not unnecessarily required and the gateway variable can be omitted when that service is absent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100