mi6 / mi6/ic-ui-kit

[ic-popover-menu] When a destructive menu item is disabled its still clickable

Open Beginner friendly
#4,479 0 comments 0 reactions 0 assignees View on GitHub
good first issue popover component
Dominant language
TypeScript
Stars
53
Forks
63
Avg merge
2d 4h
Merged PRs (30d)
15

Description

### Summary of the bug

When an `ic-menu-item` is destructive and disabled, you're still able to click on the menu item and see the text change colour to red. Whereas when the `ic-menu-item` is just default and disabled, clicking the menu item focuses it changing the background colour but not the disabled text colour.

### 🪜 How to reproduce

Go to [default popover](https://mi6.github.io/ic-ui-kit/branches/develop/web-components/?path=/story/web-components-popover-menu--default)
Click 'LOGOUT' option at the bottom of the menu
See the error

### 📸 Screenshots or code

https://github.com/user-attachments/assets/3c053ea3-9726-468e-8c03-949dc6dd92e0

### 🧐 Expected behaviour

The text should stay at the disabled text colour whether its destructive or not.

Contributor guide

Open the contributing guide

Research direction

Start with the default popover story linked in the issue and reproduce the disabled destructive LOGOUT item behavior. Trace the ic-menu-item handling and styling for disabled and destructive states, then verify that clicking it leaves the text in the disabled color for both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.