[ic-side-navigation] Long nav items get cut off + tooltips display when expanded
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 53
- Forks
- 63
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 15
Description
Summary of the bug
When you have a long nav item inside side nav and the side nav is collapsed by default, then it doesn't correctly calculate the height for the long nav item. It's just restricting it to whatever the default height is (which I think is 56px ish).
Additionally, tooltips appear next to nav-items when the side-nav is expanded, they should only appear when the side nav is collapsed. This should be addressed in this ticket too.
🪜 How to reproduce
Tell us the steps to reproduce the problem:
- Go to side nav example with long nav item
- Open the side nav
- See the error (text overflowing nav-item, being obscured) and how tooltips still appear next to nav-items)
- Open the story below it where the side nav is expanded by default, and see that the long nav item appears correctly
- Tooltips appear if you collapse and re-expand the side nav, which is incorrect.
📸 Screenshots or code
🖥 📱 Device
- Type: Desktop
- Browser: Chrome
🧐 Expected behaviour
It should appear the same whether it's expanded by default or not.
Additional info
Should probably add a Cypress test for this as it's alarming we haven't noticed it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked side-navigation stories and reproduce the issue in Chrome, then trace the side-navigation implementation used by those examples. Add the suggested Cypress regression coverage; it is done when long nav items display correctly in both initial states and tooltips appear only while the side nav is collapsed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cypress, typescript
- Domain
- frontend, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100