Internal issue 3152 - IC-SELECT and IC-MULTI-SELECT menus won't close
- Dominant language
- TypeScript
- Stars
- 53
- Forks
- 63
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 15
Description
I have an application with multiple ic-select and ic-multi-select components. And I’ve noticed then if I open the menu for one of the select components and then click onto another select component then the menu for the first select doesn’t close, instead it remains open.
I think this is a flaw in the logic in the onblur function where it tries to work out if you clicked into the menu part of the select component, but I’m not sure:
https://github.com/mi6/ic-ui-kit/blob/%40ukic/web-components%402.38.3/packages/canary-web-components/src/components/ic-select-with-multi/ic-select.tsx#L1040
You do have to click quickly between select components to recreate this defect, it’s not consistently every attempt. But it happens often enough that we’re spotting it regularly.
+*Expected*+
When I click between ic select components the menu for the previous select component should close
+*Actual*+
When I click between ic select components the menu for the previous select component remains open
Contributor guide
Research direction
Start in packages/canary-web-components/src/components/ic-select-with-multi/ic-select.tsx at the onblur logic around line 1040. Reproduce the issue by opening one ic-select or ic-multi-select menu and quickly clicking another, then verify that the previous menu closes consistently as described by the expected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100