[ic-select] correct icon size and description alignment
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 53
- Forks
- 63
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 15
Description
Summary of the bug
When displaying options in a Select, if an icon is displayed, it is 16x16px (incorrect) - whereas on Popover menu it is 24x24px (correct). If a description is displayed to this option, in Select the description text is aligned to the left of the icon (incorrect), whereas on Popover menu it is aligned to the Option label (correct).
Select options in Figma also have a checkbox which was never developed. This should be removed.
This is the same in both Figma and code.
📸 Screenshots or code
Figma version -
🧐 Expected behaviour
Select options should be displayed in the same styling as Popover Menu.
Check if a Cypress visual regression exists for this functionality. If it does, please regenerate it following the fix. If not, please add a visual regression test for this functionality
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Select and Popover Menu option implementations and check whether a Cypress visual regression already covers this functionality. Compare the icon size, description alignment, and Figma checkbox state; done means Select options use the Popover styling and the visual regression is regenerated or added.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cypress, typescript
- Domain
- design, frontend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100