mi6 / mi6/ic-ui-kit

[ic-skeleton] Add Cypress tests

Open
#4,168 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue
Dominant language
TypeScript
Stars
53
Forks
63
Avg merge
2d 4h
Merged PRs (30d)
15

Description

### Summary
Each of the components has both unit tests and Cypress tests, skeleton seems to have been missed.

### 💬 Description
I'm not sure if it was missed on purpose due to the changing skeleton colours which may cause visual regression differences. But there should at least be some end to end tests so we have different functionality covered e.g. testing that the width and height are equal when the variant is a circle.

Visual regression tests would also be ideal so we can test dark mode and high contrast mode.

### 💰 Use value
Makes us more confident in our code.

### 🚨 Urgency (low, medium or high)
Low

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the ic-skeleton component and the existing unit and Cypress tests for comparable components. Add end-to-end coverage for functionality such as equal width and height when the variant is a circle, then assess whether dark mode and high contrast visual regression coverage is supported. Done means the skeleton has comparable Cypress coverage and the tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cypress, typescript
Domain
frontend, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.