Internal issue 3121 - IcToggleButton has a border within the button when toggled
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 53
- Forks
- 63
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 15
Description
A border is added inside the perimeter of a toggled IcToggleButton which becomes apparent when the background is a different colour to the standard white or black in light / darkmode.
Demonstration of this in a [Stackblitz](https://stackblitz.com/edit/3sca81cc-umr4poof?file=src%2Fapp.tsx)
Ideally this border would be removed or removable via a prop as it looks odd with certain background colours.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Stackblitz reproduction and trace the IcToggleButton component and its styling to identify the source of the inner border when toggled. Done means the border no longer appears against non-white or non-black backgrounds, or is controllable through a prop, with the Stackblitz case no longer showing the visual issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- design, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100