mi6 / mi6/ic-ui-kit

Upgrade Stencil to latest version

Open
#3,857 3 comments 0 reactions 1 assignee Claimed by @GCHQ-Developer-112 View on GitHub
tech debt
Dominant language
TypeScript
Stars
53
Forks
63
Avg merge
2d 4h
Merged PRs (30d)
15

Description

### Summary
At time of writing, the latest version of Stencil is v4.36.2. In the package-lock.json we currently install 4.26.0. This should be upgraded as it will be required to help with SSR of the components under #3669

A quick attempt at upgrading caused the Jest unit tests to fail as all the snapshots need regenerating due to a change in the Jest DOM for shadow elements.
This was not a quick change as needs to be done for the canary components too, which have to be copied back into the core web-components directory in order to run them

Unsure as to whether there will be other issues, eg with Cypress tests, so this should be factored into the effort required to resolve this

### 💰 Use value
This will help progress towards having the components use the latest versions and be more compatible with SSR

### 🚨 Urgency (low, medium or high)
High

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.