[ic-button] dark mode hover state for icon variant
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 53
- Forks
- 63
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 15
Description
### Summary of the bug
The dark mode hover state for icon buttons looks very dark. When you hover over other buttons, the background colour/border colour goes lighter, but for icon buttons the icon itself goes darker.
### 🪜 How to reproduce
Tell us the steps to reproduce the problem:
1. Go to [button page](https://mi6.github.io/ic-design-system-githubpages/branches/develop/components/button)
2. Hover over coffee cup button
3. See the error
### 📸 Screenshots or code
### 🧐 Expected behaviour
The icon should lighten when hovered like the other buttons.
### Additional info
Might need to add Cypress tests for this, it looks like icon variants are the only ones that don't have hover/pressed state tested.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the button component shown on the linked button page and inspect the icon variant's dark-mode hover styling. Compare it with the other button variants, then check the existing Cypress hover and pressed-state tests; done means the icon lightens on hover and the relevant behavior is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cypress, typescript
- Domain
- frontend, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100