Internal issue 3053 - IcTypography overrriding styling of IcLink
- Dominant language
- TypeScript
- Stars
- 53
- Forks
- 63
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 15
Description
In V2 of ICDS, the following React code leads to an H4 element being rendered as a link, with the usual link blue coloured text:
{code:html} console.log("link clicked")}
>
Some link text
{code}
In V3 of ICDS, this is longer rendering the link with blue text, the blue coloured link text is being overridden by the black text of the IcTypography.
There is no variant property on the IcLink, hence in this example the IcTypography is required.
Contributor guide
Research direction
Start by reproducing the V3 example using IcLink with an IcTypography variant of h4, then inspect the IcLink and IcTypography component implementations. Confirm the fix preserves the h4 styling while retaining the link's blue text and click behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100