mi6 / mi6/ic-ui-kit

[dark mode] Review and rename design tokens to more appropriately match CSS mappings and their purpose

Open
#2,770 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
53
Forks
63
Avg merge
2d 4h
Merged PRs (30d)
15

Description

## Summary of the bug
> [!NOTE]
A general review of design tokens is needed now that dark mode work is completed

Some tokens moved over from design do not accurately reflect their purpose e.g.
`--ic-button-secondary-background-pressed-active` should semantically be `--ic-button-secondary-background-active`
`--ic-color-background-active-hover-light` -> `--ic-color-background-hover-light`

Most discrepancies are due to 'active' being used as 'not disabled' and 'pressed' being used instead of 'active'.

Ensure that variants of components have naming convention confluence

(List is incomplete at time of writing)

Components
- [ ] Accordion
- [ ] Alert
- [ ] Badge
- [ ] Breadcrumbs
- [ ] Buttons
- [ ] Cards
- [ ] Dropdowns
- [ ] Forms
- [ ] Headers
- [ ] Links
- [ ] Modals
- [ ] Notifications
- [ ] Pagination
- [ ] Panels
- [ ] Tables
- [ ] Tabs
- [ ] Tooltips

Contributor guide

Open the contributing guide

Research direction

No files or tests are named. Review the design tokens and CSS mappings for the listed components, using the two example renames as the starting convention; done means the token names consistently match their purpose and component variants across the completed list.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, typescript
Domain
design, frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.