mi6 / mi6/ic-ui-kit

[ic-popover] Set popover children to inherit parent theme

Open
#2,564 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

popover component
Dominant language
TypeScript
Stars
53
Forks
63
Avg merge
2d 4h
Merged PRs (30d)
15

Description

## Summary
Currently developers must set the `theme` on each instance of popover when `IcTheme` is not being used.

## 💬 Description
Set the theme on component load to match that of the parent.
![image](https://github.com/user-attachments/assets/a75c8fe5-8ae3-45c9-bc7a-8339ef21d5fb)

Another ticket has been created to handle dynamically changing `theme` prop #2563

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the ic-popover component entry point and inspect how its theme is set during component load, especially when IcTheme is not used. Confirm how the parent theme is exposed to the popover and verify that child popovers inherit it on initial load. Keep dynamic theme changes out of scope because they are tracked in issue #2563.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.