groupLinks on Footer do not update after the initial render
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 53
- Forks
- 63
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 15
Description
Summary of the bug
groupLinks on Footer do not update after the initial render
🪜 How to reproduce
Tell us the steps to reproduce the problem:
- Add a Footer with
IcFooterLinkGroupas slots andgroupLinksasfalse - Toggle
groupLinkstotrue - Watch as it does not update properly
As part of fixing this, change the defaultArgs to the default of false for groupLinks on Storybook. UPDATE: it is now possible to toggle groupLinks true/false and replicate this issue.
📸 Screenshots or code
See the Storybook playground and toggle groupLinks
🧐 Expected behaviour
groupLinks to update visually when toggled
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Footer Storybook playground and reproduce the issue by toggling groupLinks from false to true with IcFooterLinkGroup slots. Trace the Footer update path and the story's defaultArgs, then verify that the visual grouping changes in both directions and that the default is false.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- storybook, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100