mi6 / mi6/ic-ui-kit

[ic-side-navigation] escape doesn't close the menu on mobile top bar

Open
#1,921 2 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
TypeScript
Stars
53
Forks
63
Avg merge
2d 4h
Merged PRs (30d)
15

Description

## Summary of the bug
When you view side nav on a small device and open up the menu, pressing escape doesn't close the menu.

You can currently close the menu by hitting enter/space or clicking close, but I feel this should also be added in as another method of closing the menu.

## 🪜 How to reproduce
Tell us the steps to reproduce the problem:
1. Go to any side nav example
2. Reduce screen size so that the top bar behaviour shows
3. Open up the menu
4. Try to escape and see the error

## 🧐 Expected behaviour
Pressing escape should close the menu.

Contributor guide

Open the contributing guide

Research direction

Start with any side nav example, reduce the screen size until the mobile top bar appears, open the menu, and reproduce the Escape-key failure. Inspect the mobile menu handling for ic-side-navigation; done means pressing Escape closes the open menu, matching the existing Enter, Space, and close-button behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.