mi6 / mi6/ic-ui-kit

[ic-side-navigation/ic-navigation-item] when selected and focused the icon is not centred

Open
#1,920 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
53
Forks
63
Avg merge
2d 4h
Merged PRs (30d)
15

Description

## Summary of the bug
When you focus a selected navigation item in the collapsed state, the icon is not in the centre of the focus.

Need design input on this because if we add a margin so that the icon is centred within the focus then it won't align with the rest of the navigation items which are unfocused.

## 🪜 How to reproduce
Tell us the steps to reproduce the problem:
1. Go to any side nav example
2. Focus the selected navigation item
3. See the error

## 📸 Screenshots or code
Screenshot 2024-05-24 at 09 42 39

## 🧐 Expected behaviour
The icon should be centred within the focus.

Contributor guide

Open the contributing guide

Research direction

Start with the ic-side-navigation/ic-navigation-item component and reproduce the issue in any side nav example by focusing the selected item in its collapsed state. Compare the focused icon position with the focus area and the other navigation items. Done means the icon is centred within the focus while the navigation remains visually consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
design, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.