mi6 / mi6/ic-ui-kit

[ic-hero] background image implementation doesn't match design

Open
#1,884 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
53
Forks
63
Avg merge
2d 4h
Merged PRs (30d)
15

Description

## Summary of the bug
From Figma, it looks like the background image on smaller devices is meant to appear above all other hero content. However, in the implementation, the background image just disappears on smaller devices.

## 🪜 How to reproduce
Tell us the steps to reproduce the problem:
1. Go to background image example on storybook
2. Change to small device
4. See the error

## 📸 Screenshots or code
Figma designs -
Screenshot 2024-05-20 at 10 28 21

## 🧐 Expected behaviour
Hero with background image should match Figma designs.

## Additional info
Question for design - what should happen if parallax isn't disabled? Do we want to disable it for small devices?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the background image example in Storybook and compare its small-device rendering with the linked Figma design. Confirm the intended parallax behavior with design; done means the hero background remains visible and matches the small-device layout.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
design, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.