Internal issue 2740
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 53
- Forks
- 63
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 15
Description
Currently IcDialog has various size options, which limit the size of the dialog. I’m suggesting there be a “full” option for the size prop, which would allow the dialog and it’s content (already possible by the disableWidthConstraint prop for large dialogs) to expand to the full size of the screen (minus some padding around the outside) if the content of the dialog warranted it.
The use case that has brought this suggestion is that I’d like to use the dialog component as an image lightbox for showing images as their true size. For examples if an image has a detailed diagram that is hard to see when it's size is constrained.
internal issue number 2740
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the IcDialog component and its size prop implementation, then inspect how disableWidthConstraint currently affects large dialogs. Done means adding a full size option that lets the dialog and its content use the available screen size while preserving padding around the outside, including the image lightbox use case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100