mherrmann / mherrmann/fman

Pack command throws an errror

Open
#774 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

windows
Dominant language
Python
Stars
275
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Hi there.
I'm using Win10.
When trying to use the pack command to zip a folder I'm getting this error:

Command 'Pack' raised error.

Traceback (most recent call last):
File "fman\impl\plugins\command_registry.py", line 128, in execute_command
File "C:\Users\viore\AppData\Local\fman\Versions\1.7.3\Plugins\Core\core\commands_init
.py", line 1699, in call
submit_task(Pack(files, dest_rewritten))
File "fman_init
.py", line 323, in submit_task
File "C:\Users\viore\AppData\Local\fman\Versions\1.7.3\Plugins\Core\core\commands_init_.py", line 1712, in call
self.run(task)
File "fman_init_.py", line 309, in run
File "C:\Users\viore\AppData\Local\fman\Versions\1.7.3\Plugins\Core\core\fs\zip.py", line 321, in call
self._zip_fs.notify_file_added(dest_path)
File "tempfile.py", line 809, in exit
File "tempfile.py", line 813, in cleanup
File "shutil.py", line 494, in rmtree
File "shutil.py", line 384, in _rmtree_unsafe
File "shutil.py", line 389, in _rmtree_unsafe
File "shutil.py", line 387, in _rmtree_unsafe
PermissionError: [WinError 5] Access is denied: 'C:\Users\viore\AppData\Local\Temp\tmpih9ilc4s\.NET Internals and Advanced Debugging Techniques\0 Introduction and Overview 20111221191129.mp4'

Can you please take a look?
If more info is needed please ask.
Thx!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Pack command in core/commands/init.py around line 1699 and the cleanup path in core/fs/zip.py around line 321. Reproduce the Windows 10 failure while packing a folder containing the reported MP4, then verify that the temporary directory is cleaned up and Pack completes without PermissionError.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.