mherrmann / mherrmann/fman

Gracious rollback when an error occurs while moving files

Open
#75 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
275
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Possible solutions, kindly proposed by @kek91:

  • Make the rollback function COPY back the files instead of moving them back. Yes, the user would wind up with 2 copies, but at least it's there

  • Change the move command entirely so it actually makes a copy first and then when the copy is finished delete the source.

  • Implement a check before initialising the move command to see if any source files are locked/not writeable, if so fman could show a warning prompt and the user can safely click cancel before doing any damage

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. First trace the move command and rollback function, then clarify which of the three proposed approaches is desired and how locked files should be handled; done should preserve recoverable files and avoid destructive partial moves when an error occurs.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.