mherrmann / mherrmann/fman

Make show_prompt(...) return a single value

Open
#260 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

API enhancement
Dominant language
Python
Stars
275
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Currently, it returns a tuple text, ok. When the user cancelled, '', False is returned. The aim of this issue is to return a single value instead. If the user presses OK in the dialog, whatever text was entered is returned as a string (possibly empty). If the user presses Cancel, None should be returned.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search for show_prompt(...) and its callers, then inspect how the dialog distinguishes OK from Cancel. Done means OK returns the entered string, including an empty string, while Cancel returns None, with callers handling the single returned value.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.