mherrmann / mherrmann/fman

Problem moving nested folder to Recycle Bin

Open
#239 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug windows
Dominant language
Python
Stars
275
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Create a nested directory temp\sub. Open the parent of temp in the left pane, temp\sub in the right pane. Try to delete temp in the left pane. Get an error:

Command 'MoveToTrash' raised error.

Traceback (most recent call last):
  File "fman\impl\plugins\plugin.py", line 270, in _run_in_thread
  File "C:\Users\Michael\dev\fman\target\fman\Versions\0.7.0\Plugins\Core\core\commands.py", line 117, in __call__
    move_to_trash(url)
  File "fman\fs.py", line 25, in move_to_trash
  File "fman\impl\plugins\mother_fs.py", line 93, in move_to_trash
  File "C:\Users\Michael\dev\fman\target\fman\Versions\0.7.0\Plugins\Core\core\fs\local.py", line 51, in move_to_trash
    move_to_trash(path)
  File "C:\Users\Michael\dev\fman\target\fman\Versions\0.7.0\Plugins\Core\core\trash.py", line 13, in move_to_trash
    send2trash(file)
  File "C:\Users\Michael\dev\fman\target\fman\Versions\0.7.0\Plugins\Core\send2trash\plat_win.py", line 58, in send2trash
    raise OSError(msg)
OSError: Couldn't perform operation. Error code: 120

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the Windows case with temp\sub open in the opposite pane, then trace MoveToTrash through fman/fs.py, mother_fs.py, core/fs/local.py, core/trash.py, and send2trash/plat_win.py. Done means deleting the parent directory moves it to the Recycle Bin without the reported error code 120.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.