mgradwohl / mgradwohl/Butternut

Don't use Magic Numbers

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

AnkerConfigDialog
```
void AnkerConfigDlg::resetPresetComBoxHighlight() {
if (m_printerPresetsChoice) {
m_printerPresetsChoice->setColor(wxColour("#434447"),
wxColour("#3A3B3F"));
```

Those numbers should be defined somewhere so that if you change them in one place, they change everywhere. A typo in any file will mess up your colors.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at AnkerConfigDlg::resetPresetComBoxHighlight and search the project for the two color literals shown in the issue. Identify where the repeated color values are used, then verify that changing each shared definition updates all corresponding uses without changing the intended colors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.