mgechev / mgechev/ngx-quicklink
Errors during route preloading are not handled
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 757
- Forks
- 43
- PR merge metrics
- No merged PRs in 30d
Description
The logic that initiates preloading of a lazy route doesn't handle potential load errors (e.g. bad network connection) so they are thrown. I think preloader should ignore them as they're not critical but we have to ensure they don't break the app and router will initiate loading of the failed module after user navigates to the corresponding route.
Here is the stacktrace of one of such errors:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the lazy-route preloading logic in the Angular router integration and reproduce a failed module load, such as with a bad network connection. Confirm that the preloader does not throw or break the app, and that navigating to the affected route still initiates loading of the failed module.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- frontend, performance
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100