mgechev / mgechev/eap-feedback

Redux Devtools floods profiler event list

Open
#2 5 comments 1 reaction 0 assignees View on GitHub
Dominant language
No language data
Stars
10
Forks
0
PR merge metrics
No merged PRs in 30d

Description

tl;dr; `message` events trigger CD which makes the Profiler unusable together with Redux DevTools

----

- Project with NgRx, `StoreDevToolsModule` and Redux DevTools Chrome Extension
- NgRx and Redux DevTools communicate through `window.postMessage`
- `message` events trigger Change Detection and flood the profiler event list
- the profiler is not really usable without disabling the Redux DevTools

Example project: https://github.com/angular-schule/2021-03-angular-workshop-online/tree/main/book-rating

![Screenshot 2021-03-19 at 10 27 24](https://user-images.githubusercontent.com/1683147/111759276-b30abb00-889d-11eb-806b-d9f0d49e60ab.png)

This problem is not specifically related to the Angular DevTools, but I never noticed this behavior before.
It could be solved on the NgRx or Redux DevTools side, but it would be cool to have a solution within Angular DevTools for this, too.

### Idea
- some sort of filtering for event type
- or ignoring specific events (or event sources?)

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the issue with the linked book-rating example, NgRx, StoreDevToolsModule, and the Redux DevTools Chrome extension. Start by tracing how window.postMessage events enter the profiler event list; done means profiling remains usable without disabling Redux DevTools, with a defined way to filter or ignore the relevant events.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, redux
Domain
devtools, performance
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.