Fixer should not be added when using custom template transformation without sourcemaps
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.5k
- Forks
- 232
- PR merge metrics
- No merged PRs in 30d
Description
This relates to me trying to use pug with codelyzer here:
https://github.com/mgechev/codelyzer/issues/880
The problem is that I don't have sourcemaps.
When I use tslint --fix, any template rules that have a fixer (I've just tried angular-whitespace) will update the code incorrectly.
I think it would be best if codelyzer didn't attempt to add a fix, if a custom transformTemplate function is used and no sourcemap is provided.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace how custom transformTemplate is handled and how template-rule fixers are added when sourcemaps are absent. Reproduce the pug and codelyzer scenario with tslint --fix, then verify that no fixer is added for a custom transformation without a sourcemap while normal sourcemap-based fixes remain available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100