mgechev / mgechev/codelyzer

"i18n": [false,"check-text"] fails on text containing only non-word characters

Open
#618 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
2.5k
Forks
232
PR merge metrics
No merged PRs in 30d

Description

Is there a way to use the `"i18n": [false,"check-text"]` rule would pass for any text node containing only numbers or other non-word symbols even if the wrapper element is missing the `i18n` attribute?

If not, could this be added as a config option?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation and tests for the i18n check-text rule, then reproduce the behavior with text nodes containing only numbers or other non-word symbols. Determine whether the rule can pass those nodes without a wrapper i18n attribute or needs a configuration option; done means the chosen behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
internationalization, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.