mgechev / mgechev/codelyzer

about no-conflicting-life-cycle-hooks

Open
#588 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
2.5k
Forks
232
PR merge metrics
No merged PRs in 30d

Description

no-conflicting-life-cycle-hooks should prevents this:

Note that a directive typically should not use both DoCheck and OnChanges to respond to changes on the same input, as ngOnChanges will continue to be called when the default change detector detects changes.

Currently, it doesn't seem to be the case. We just check if we use the both hooks in same time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the no-conflicting-life-cycle-hooks rule and inspect how it detects DoCheck and OnChanges usage. Add or update rule coverage for hooks used on the same input, distinguishing it from hooks used on different inputs. Done means the rule reports the conflicting same-input case described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.