mgechev / mgechev/codelyzer

i18n rule check-text does not work

Open
#497 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
2.5k
Forks
232
PR merge metrics
No merged PRs in 30d

Description

- codelyzer 4.1.0
- Angular 5.2.1
- TypeScript 2.6.2

` "i18n": [true, "check-text"]` does not work for this examples:

```


Veröffentlichen

```

> edit-article.component.html[35, 110]: Each element containing text node should have an i18n attribute

or

```

{{user.firstName}} {{user.lastName}} (Rollen: {{user.roles}})


Anwender wird geladen...
```

> ERROR: user.component.html[2, 75]: Each element containing text node should have an i18n attribute

And can you please explain which codelyzer rules are stable and production ready and which not? For example you said that the no-unused-css rule is not stable (here https://github.com/mgechev/codelyzer/issues/364) and this i18n rule seems to be unstable as well.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the i18n rule's check-text behavior and reproduce the reported diagnostics in edit-article.component.html and user.component.html using the listed codelyzer, Angular, and TypeScript versions. Confirm whether these examples should pass, then add or update coverage for the cases and document which rules are stable and production ready.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
internationalization, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.