mevdschee / mevdschee/php-crud-api

Missing insert value on not null without default should fail

Open
#385 6 comments 0 reactions 1 assignee View on GitHub

@mevdschee is already working on this.

Since May 28, 2018.

enhancement
Dominant language
PHP
Stars
3.7k
Forks
1k
Avg merge
1h 55m
Merged PRs (30d)
7

Description

I searched the issues and checked the README and have not yet found any mention of this.

Is it expected to be the case that columns with a NOT NULL definition and no default value should be allowed/inserted with an empty string when none was provided? My hope/expectation would be that it would return the error from the DB when it attempts this (rather than just inserting a blank string). I did see that for most create/update actions, null is returned when the call fails (which can be a handy indicator of some error condition, but only when it is null and values aren't just remapped to blank strings and inserted silently.)

Thoughts?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.