metosin / metosin/sieppari

Non AsyncContext & map-like contexts should fail fast

Open
#41 2 comments 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
Clojure
Stars
218
Forks
20
PR merge metrics
No merged PRs in 30d

Description

Currently, if a context is neither, it will do something undefined, most likely fails, but could just do nothing. If it's neither, we should blow up in a manged way, relevant code here: https://github.com/metosin/sieppari/blob/develop/src/sieppari/core.cljc#L36-L43

This happens for example when someone returns a `core.async` channel, without having it registered as a valid AsyncContext.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with src/sieppari/core.cljc lines 36-43, where non-AsyncContext and map-like contexts are handled. Trace the example of an unregistered core.async channel and define the managed failure for values matching neither context type. Done means unsupported contexts fail explicitly instead of being ignored or behaving undefinedly.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.