meteor / meteor/blaze

Improve Exception Reporting

Open
#291 10 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

  • #368 by @jankapunkt — closed without merging
ready
Dominant language
JavaScript
Stars
543
Forks
117
Avg merge
6h 18m
Merged PRs (30d)
2

Description

Currently in Kadira we get lots of exceptions that look like this:
[client] Exception in tempalte helper:

As there is no more detail they all get grouped together which can be painful to wade through.

One simple update we could make in Blaze is to pass the name of the helper function to _wrapCatchingException (in lookup.js) so
```
return Blaze._wrapCatchingExceptions(f, 'template helper').apply(self, args);
```
Would be instead something like
```
return Blaze._wrapCatchingExceptions(f, `template helper ${templateFunc.name}`).apply(self, args);
```
It would be even better if we passed the actual template name into wrapHelper and then we could report that too meaning a unique grouping by template name and helper in Kadira or whatever other error handling program someone is using.

I'm happy to make the PR if whoever monitors this agrees :smiley:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in lookup.js, focusing on wrapHelper and _wrapCatchingExceptions, then review the closed linked pull request #368 for prior work. Determine how helper and template names can be included in exception reports so different helpers group separately in Kadira or other error handlers; the issue is done when that context is reported consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.