layoutComplete stopped triggering when items get hidden
- Dominant language
- JavaScript
- Stars
- 4.3k
- Forks
- 324
- PR merge metrics
- No merged PRs in 30d
Description
The a few items get hidden by style="display:none" the layoutComplete event stopped triggering. In some scenario it's impossible to use Packery.remove as the item needs to be visible later.
See the updated layoutComplete example http://codepen.io/anon/pen/yEkIF where the remove method was replaced by
// make hidden
event.target.style.display = 'none';
//classie.toggle( event.target, 'gigante' );
After hiding 2-4 items the notification doesn't appear.
Contributor guide
Research direction
Start with the updated layoutComplete example at http://codepen.io/anon/pen/yEkIF and reproduce the issue by hiding items with style="display:none" instead of calling Packery.remove. Trace why layoutComplete stops notifying after 2–4 items are hidden, while preserving the ability to make those items visible later. Done means the event notification appears reliably in that example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100