metafizzy / metafizzy/outlayer
Wiredep bug - item.js missing in bower.json main
- Dominant language
- JavaScript
- Stars
- 166
- Forks
- 63
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
It appears that commit 914f1f2 introduced a bug:
https://github.com/metafizzy/outlayer/commit/914f1f2fa9874935dc7723a5a1171e0f78a689e7#diff-a63318b17de3bf77b5cd6eb71e7aae44R46
How can `window.Outlayer.Item` be defined before assigning the result of the `factory` call to `window.Outlayer` ?
My Karma tests fail on this when launching PhantomJS, with the following error:
```
Running "karma:dev" (karma) task
INFO [karma]: Karma v0.12.31 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
INFO [PhantomJS 1.9.8 (Windows 8)]: Connected on socket _xqtqhxXOy8qR62SOmNJ with id 26908454
PhantomJS 1.9.8 (Windows 8) ERROR
TypeError: 'undefined' is not an object (evaluating 'window.Outlayer.Item')
at src/main/bower_components/outlayer/outlayer.js:42
```
Or did I got the root cause wrong ?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reviewing commit 914f1f2 and the referenced outlayer.js location, then reproduce the failure with the Karma dev task in PhantomJS. Done means window.Outlayer.Item is available as expected and the reported PhantomJS test error no longer occurs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100