metafizzy / metafizzy/outlayer
Fallback nicely if new Layout({})
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 166
- Forks
- 63
- PR merge metrics
- No merged PRs in 30d
Description
Should bail nicely if user enters non-element argument for new Layout(). Fixes regression with Packery tests.
should get utils.isElement( queryElement )
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the Layout constructor and the utility containing utils.isElement, then review the Packery tests that exposed the regression. The change is done when new Layout({}) handles a non-element argument without failing and the relevant Packery tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100