metafizzy / metafizzy/outlayer

Do not layout items that are isHidden

Open
#14 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
166
Forks
63
PR merge metrics
No merged PRs in 30d

Description

Per desandro/masonry#496, items that are isHidden should not need to be laid out. Consider changing `_getItemsForLayout` to

``` js
Masonry.prototype._getItemsForLayout = function( items ) {
var layoutItems = [];
for ( var i=0, len = items.length; i < len; i++ ) {
var item = items[i];
if ( !item.isIgnored && !item.isHidden ) {
layoutItems.push( item );
}
}
return layoutItems;
};
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating Masonry.prototype._getItemsForLayout and inspect how it filters items before layout. Verify that items with isHidden are excluded while non-hidden items retain their existing behavior; the issue does not name a test file or test command.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.