metafizzy / metafizzy/isotope

Container Height with a Stamp and columnWidth

Open
#1,237 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
HTML
Stars
11.1k
Forks
1.4k
PR merge metrics
No merged PRs in 30d

Description

Hi,

When you set a `columnWidth` for the `masonry` option of isotope, and use stamp, the layout method does not calculate the height as it should with a stamp.

In other words: if you have a stamp, and you've set a `columnWidth`, so; When there are no items in the grid, and you try to relayout everything, the container will set its height to 0 without considering the stamp.

Demo: http://codepen.io/anon/pen/gmXPyE
In the demo, click on **remove all** and then on **layout** and see the problem.

Is it a bug? becuase it hurts the performance and user experience in my website.

thanks!

Contributor guide

Open the contributing guide

Research direction

Start with the linked CodePen demo and reproduce the sequence of removing all items, then triggering layout, with masonry columnWidth and a stamp configured. Trace the masonry layout behavior involved in that sequence; done means the container height still accounts for the stamp when no grid items remain.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.