metafizzy / metafizzy/infinite-scroll

Infinite Scroll altering request URL

Open
#915 13 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
HTML
Stars
7.5k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

Hey,

I have a very strange issue with Infinite Scroll. Well, I THINK it is Infinite Scroll. I honestly can't see what else is causing it.

Go here: https://dev.neiltonge.co.uk/parks/coasters?sort=order If you choose “2019” from the “All years” select box about halfway down, then scroll to the bottom of the grid and click “View more coasters”. That works fine. If you scroll back up and check the checkbox next to “New in 2019” and now try to “View more coasters”. You’ll see it says there are no more to load, even though the pagination above the grid says otherwise. It took me a while to figure out what was happening but if you check the network inspector whilst clicking the button with the select box and checkbox set, you’ll see that the URL it’s requesting from is all good apart from it’s changed the “ridden_in” parameter from “2019” to “219”. Therefore no results. This is really confusing because the pagination "next" link works fine. I’m completely baffled by this one.

Thanks

Contributor guide

Open the contributing guide

Research direction

Reproduce the case at the linked parks/coasters URL with the 2019 select value and “New in 2019” checkbox enabled. Use the network inspector to compare the Infinite Scroll request with the working pagination “next” link, focusing on the changed “ridden_in” parameter. Done means “View more coasters” requests the correct value and loads the remaining results.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, jquery
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.