metafizzy / metafizzy/infinite-scroll
IE11: cannot set history with different origin
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 7.5k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
in ie 11 the line 47 history.js incorrectly fulfills:
`var linkOrigin = link.origin || link.protocol + '//' + link.host;`
The fact is that link.host also includes a protocol and it turns out that
`"https://hostname.com" !== "https://hostname.com:80"`
To fix, you can write something like this:
`var linkOrigin = link.origin || (link.protocol + '//' + link.host).replace(':' + link.port, '');`
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with line 47 of history.js, where linkOrigin is assembled for IE11. Reproduce the different-origin history case and verify the origin comparison handles the port correctly; done means IE11 no longer rejects a valid history update for this case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100