metafizzy / metafizzy/flickity

Flickity Fullscreen option on Shopify store

Open
#1,308 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
7.6k
Forks
593
PR merge metrics
No merged PRs in 30d

Description

Hi guys,

having this code in the Shopify custom liquid section for Flickity slider does not allow fullscreen display of individual images in the slider. Is there anything I'm doing wrong? I know I have to attach fullscreen libraries separately, but I did that and it still doesn't work.

{{ "flickity.css" | asset_url | stylesheet_tag }}
{{ "fullscreen.css" | asset_url | stylesheet_tag }}
{{ "mc-custom-slider.css" | asset_url | stylesheet_tag }}
{{ "animate.min.css" | asset_url | stylesheet_tag }}

<div class="carousel" data-flickity='{ "fullscreen": true, "wrapAround": true, "freeScroll": true, "pageDots": false, "draggable": true }'>
    {%- for block in section.blocks -%}
    <div>
        <img src="{{ block.settings.desktopImage | img_url: 'master'}}" alt="{{ block.settings.desktopImage.alt }}"/>
    </div>
    {%- endfor -%}
</div>

{{ 'jquery-3.6.1.js' | asset_url | script_tag }}
{{ 'flickity.pkgd.js' | asset_url | script_tag }}
{{ 'fullscreen.js' | asset_url | script_tag }}



{% schema %}
{
    "name": "Flickity Slideshow",
    "settings": [
      
    ],
    "blocks" : [
      {
        "type" : "column",
        "name" : "slide",
        "settings" : [
          {
            "type": "image_picker",
            "id" : "desktopImage",
            "label" :  "Desktop Image"
          }
        ]
      }
    ],
    "presets": [
      {
        "name": "Flickity Slider"
      }
    ]
  }
{% endschema %}


Thank you!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No repository file or test is named. Start by reproducing the supplied Shopify custom Liquid snippet with Flickity and the separately loaded fullscreen assets, then verify whether the fullscreen option works for the generated carousel. Done means identifying a reproducible cause and documenting a concrete resolution or confirming the issue is external to Flickity.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.