metafizzy / metafizzy/flickity

Do not set aria-hidden on elements visible in the viewport

Open
#1,228 15 comments 12 reactions 0 assignees View on GitHub
feature request
Dominant language
JavaScript
Stars
7.6k
Forks
593
PR merge metrics
No merged PRs in 30d

Description

This is an amazing library. Kudos to the devs!

I noticed an accessibility issue in the slider.
The issue is that `aria-hidden` attribute is being set to `true` for elements which are in the slider view.
Please see this reproduction I made: https://codepen.io/geon-halfhelix/pen/YzeEbLj

![image](https://user-images.githubusercontent.com/98684094/170481095-3d74fba9-91ee-4eb1-8791-4233e59fb396.png)

Contributor guide

Open the contributing guide

Research direction

Start with the linked CodePen reproduction and trace how the slider assigns aria-hidden to visible elements. The fix is done when elements currently in the viewport are not marked aria-hidden; verify the behavior against the reproduction and relevant accessibility checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
56/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.