metafizzy / metafizzy/flickity

Semantic feature | Set the tag element which wrap the slides

Open
#1,160 8 comments 12 reactions 0 assignees View on GitHub
feature request
Dominant language
JavaScript
Stars
7.6k
Forks
593
PR merge metrics
No merged PRs in 30d

Description

In order to improve the semantic of the user sliders, would be great to have an `option` like
```typescript
flickitySliderTag: 'dl' | 'ul' | 'ol' | 'div'
```

Right now i can use a main wrapper as `

    ` for example, but thats wrong, since library add two divs before actually appending the slides, and the `
  1. ` must be direct child of `
      ` or `
        `
        ([See permitted content for `
          ` on developer.mozilla.org](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ol))

          The desired result is the following, see image (i just changed the tags with the inspector in the Demo page to create the sample)

          Screenshot 2021-05-05 at 15 42 46

Contributor guide

Open the contributing guide

Research direction

Start from the code that creates the slider wrapper and review the demo markup. Implement the requested option so the slide wrapper can use the listed tag names while preserving valid list semantics, then verify the resulting DOM in the demo.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.