metafizzy / metafizzy/flickity-fullscreen

full screen entry image ratio is wrong

Open
#6 7 comments 0 reactions 1 assignee Claimed by @desandro View on GitHub
Dominant language
HTML
Stars
49
Forks
16
PR merge metrics
No merged PRs in 30d

Description

I have a slider with images of different widths and heights and I have borrowed from the Flickity options example for fullscreen image carousels centered in cells the CSS. I have:

```
carousel {
background: #EEE;
}

.carousel-cell {
min-height: 100%;
}

.carousel.is-fullscreen .carousel-cell {
height: 100%;
min-width: 100%;
display: flex;
align-items: center;
justify-content: center;
}

.carousel.is-fullscreen .carousel-cell-image {
height: 100%;
max-width: 100%;
}

.carousel-cell-image {
display: block;
margin-right: 5px;
}
```

The fullscreen slider works on Chrome on an old IOS iPad, Firefox on Windows 10 and FreeBSD, Edge on Windows 10 however and fails on a recent IOS with Chrome, Safari and Brave, Sarfari on MacOS, and Chrome on Windows. The images do not display when entering fullscreen with an incorrect aspect ratio as if the normal size is being used. The images are too narrow for the height. If I resize the browser while in fullscreen with Safari on MacOS all images are displayed correctly and stay that way. On Window's Chrome if I toggle `display: flex;` off then on in Chrome's inspector for the `.carousel.is-fullscreen .carousel-cell` all images are displayed correctly.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.