Params in query call possible ?
Nobody has claimed this yet.
- Dominant language
- Clojure
- Stars
- 576
- Forks
- 48
- PR merge metrics
- No merged PRs in 30d
Description
I have been looking at the code here https://github.com/metabase/toucan/blob/e8fbd6dde8452f72ae9adb1c8b1dd3ca757e3129/src/toucan/db.clj#L284 from what I can tell query does not take :params to pass in parameters ? or else I am not understanding whats going on.
Tried a few things like
` (db/query honey-sql-query :search "text")`
But this does not work, the doc string says it takes a honey sql form which i Take it is just the hash map form before its passed to sql/format which has a :params keyword to allow you to injected name params into your query.
@camsaul is this possible am i missing something, or would toucan need to be extended to allow for this ?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read src/toucan/db.clj around line 284 and trace the db/query entry point alongside the Honey SQL form and its :params handling. Confirm whether named parameters can be passed through the current interface; done means the requested query call behavior is supported or its limitation is clearly established with coverage for the resulting behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure, sql
- Domain
- database
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100