metabase / metabase/toucan

Should insert-many! call post-insert on inserted objects?

Open
#4 1 comment 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Clojure
Stars
576
Forks
48
PR merge metrics
No merged PRs in 30d

Description

Seems like this makes sense since it calls `pre-insert`. People can always use `simple-insert-many!` instead to avoid this behavior

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the implementation of `insert-many!` and compare its existing `pre-insert` behavior with `simple-insert-many!`. Check how `post-insert` is handled for inserted objects; done means the behavior is consistent with the chosen API semantics and is covered by relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
database
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.